| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Simplify plpgsql's check for simple expressions. |
| Date: | 2017-08-15 22:08:47 |
| Message-ID: | CA+Tgmoa+h--4STWwP-+XkrSwcU8wWtNCV7ODcQZgyy=Xi+Np6g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Tue, Aug 15, 2017 at 5:15 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> The idea of the existing
> code seems to be "let's exercise what happens if the executor does
> EnterParallelMode/ExitParallelMode around any plan whatsoever, even a
> parallel-unsafe one"; which seems to me to be bogus as heck.
I think that is not what the current code is doing. If the plan is
diagnosed as parallel-unsafe, then parallelModeOK will be false and
nothing will happen. If the plan is actually parallel-unsafe but the
planner doesn't *think* it's parallel-unsafe, then what you are
talking about will happen, but that seems to me to be a good thing.
It lets you find planner bugs (or functions that a user has labelled
incorrectly).
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-08-15 22:40:42 | Re: [COMMITTERS] pgsql: Simplify plpgsql's check for simple expressions. |
| Previous Message | Tom Lane | 2017-08-15 21:15:27 | Re: [COMMITTERS] pgsql: Simplify plpgsql's check for simple expressions. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2017-08-15 22:09:47 | Re: Simplify ACL handling for large objects and removal of superuser() checks |
| Previous Message | Andres Freund | 2017-08-15 22:06:53 | Re: POC: Sharing record typmods between backends |