| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | "Shinoda, Noriyoshi (PN Japan FSIP)" <noriyoshi(dot)shinoda(at)hpe(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Jeevan Ladhe <jeevanladhe(dot)os(at)gmail(dot)com>, Dipesh Pandit <dipesh(dot)pandit(at)gmail(dot)com>, Abhijit Menon-Sen <ams(at)toroid(dot)org>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com> |
| Subject: | Re: refactoring basebackup.c |
| Date: | 2022-02-16 16:16:25 |
| Message-ID: | CA+Tgmoa+TSF2a=Bi8dnU-uzq2J6ebkBSUXDJ3MFiBHpn1Jrq3A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Feb 16, 2022 at 11:11 AM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> This is hard to interpret for humans though because of the nested
> brackets and braces. It gets considerably easier if you split it in
> separate variants:
>
> -Z, --compress=[{client|server}-]{gzip|lz4}[:LEVEL]
> -Z, --compress=LEVEL
> -Z, --compress=none
> compress tar output with given compression method or level
>
>
> or, if you choose to leave the level-only variant undocumented, then
>
> -Z, --compress=[{client|server}-]{gzip|lz4}[:LEVEL]
> -Z, --compress=none
> compress tar output with given compression method or level
>
> There still are some nested brackets and braces, but the scope is
> reduced enough that interpreting seems quite a bit simpler.
I could go for that. I'm also just noticing that "none" is not really
a compression method or level, and the statement that it can only
compress "tar" output is no longer correct, because server-side
compression can be used together with -Fp. So maybe we should change
the sentence afterward to something a bit more generic, like "specify
whether and how to compress the backup".
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2022-02-16 16:44:42 | Re: USE_BARRIER_SMGRRELEASE on Linux? |
| Previous Message | Peter Geoghegan | 2022-02-16 16:12:53 | Re: do only critical work during single-user vacuum? |