Re: Small improvement to parallel query docs

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Brad DeJong <Brad(dot)Dejong(at)infor(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Small improvement to parallel query docs
Date: 2017-02-14 14:41:34
Message-ID: CA+Tgmoa+4c4Lz_a35RzuMxfO6ggiikVHA+dFSdMy=64-VLqLPQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Feb 14, 2017 at 5:17 AM, David Rowley
<david(dot)rowley(at)2ndquadrant(dot)com> wrote:
> On 14 February 2017 at 21:25, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>> + Aggregate</> stage. For such cases there is clearly going to be no
>> + performance benefit to using parallel aggregation.
>>
>> A comma is required after "For such cases"
>
> Added
>
>>> The query planner takes
>>> + this into account during the planning process and will choose how to
>>> + perform the aggregation accordingly.
>>
>> This part of the sentence sounds unclear. It doesn't clearly
>> indicate that planner won't choose a parallel plan in such cases.
>
> I thought that was obvious enough giving that I'd just mentioned that
> there's clearly no benefit, however I've changed things to make that a
> bit more explicit.
>
> Thanks for reviewing this.
>
> Updated patch attached.

Committed and back-patched to 9.6.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-02-14 14:44:11 Re: UPDATE of partition key
Previous Message Robert Haas 2017-02-14 14:24:16 Re: removing tsearch2