| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, David Steele <david(at)pgmasters(dot)net>, Ildus Kurbangaliev <i(dot)kurbangaliev(at)gmail(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Custom compression methods |
| Date: | 2021-02-09 20:59:32 |
| Message-ID: | CA+TgmoZzP2-Y4V66oQcPgdTvb_vcRL+=8gysYVtyG9a5HpfR-Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Feb 9, 2021 at 3:37 PM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> I think you misunderstood: I mean that the WIP patch should default to
> --enable-lz4, to exercise on a few CI. It's hardly useful to run CI with the
> feature disabled. I assume that the patch would be committed with default
> --disable-lz4.
Oh, I see. I guess we could do that.
> Right, it's not one-time, it's also whenever setting a non-default compression
> method. I say it should go into 0001 to avoid a whole bunch of churn in
> src/test/regress, and then more churn (and rebase conflicts in other patches)
> while adding HIDE_COMPRESSAM in 0002.
Hmm, I guess that makes some sense, too.
I'm not sure either one is completely critical, but it does make sense
to me now.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2021-02-09 21:12:22 | Re: [POC] verifying UTF-8 using SIMD instructions |
| Previous Message | Justin Pryzby | 2021-02-09 20:37:37 | Re: [HACKERS] Custom compression methods |