| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com> |
| Cc: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Partition-wise aggregation/grouping |
| Date: | 2018-03-22 16:58:03 |
| Message-ID: | CA+TgmoZxT6RFXPipUiPS3MPvHN0Jd6bXm7HAnpa0_ZRvZh4wWQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 22, 2018 at 6:15 AM, Jeevan Chalke
<jeevan(dot)chalke(at)enterprisedb(dot)com> wrote:
> Leeks cleaner now. Thanks for refactoring it.
>
> I have merged these changes and flatten all previuos changes into the main
> patch.
Committed 0001-0005. I made a few further modifications. These were
mostly cosmetic, but with two exceptions:
1. I moved one set_cheapest() call to avoid doing that twice for the
top-level grouped_rel.
2. I removed the logic to set partition properties for grouped_rels.
As far as I can see, there's nothing that needs this. It would be
important if we wanted subsequent planning stages to be able to do
partition-wise stuff, e.g. when doing window functions or setops, or
at higher query levels. Maybe we'll have that someday; until then, I
think this is just a waste of cycles.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2018-03-22 17:17:41 | Re: pgstat_report_activity() and parallel CREATE INDEX (was: Parallel index creation & pg_stat_activity) |
| Previous Message | Simon Riggs | 2018-03-22 16:57:34 | Re: [HACKERS] Surjective functional indexes |