Re: improving user.c error messages

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: improving user.c error messages
Date: 2023-01-27 15:53:54
Message-ID: CA+TgmoZvrsrpp=c2x=6HBHxOoXcu4TyQ6JnMkcGVrCHAn+V=8w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jan 27, 2023 at 10:52 AM Nathan Bossart
<nathandbossart(at)gmail(dot)com> wrote:
> IMHO superuser should typically only be mentioned when it is the only way
> to do something. Since superusers have all privileges, I think logs like
> "superuser or privileges of X" are kind of redundant. If Robert has
> privileges of X, we wouldn't say "privileges of X or Robert." We'd just
> point to X. Ultimately, I feel like mentioning superuser in error messages
> usually just makes the message longer without adding any useful
> information.

That's kind of my opinion too, but I'm not sure whether there are
cases where it will lead to confusion.

--
Robert Haas
EDB: http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2023-01-27 16:01:51 Re: Set arbitrary GUC options during initdb
Previous Message Tom Lane 2023-01-27 15:53:42 Re: Set arbitrary GUC options during initdb