| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Morten Hustveit <morten(at)eventures(dot)vc>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Suggestion: Issue warning when calling SET TRANSACTION outside transaction block |
| Date: | 2013-11-19 18:11:06 |
| Message-ID: | CA+TgmoZvJLqTve8ipfqwGcvjNWVZay9C0YVT=ff1_Rci4FVkMg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 19, 2013 at 1:05 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> A patch to issue only warnings is attached. In a way this change
> improves the code by throwing errors only when the commands are invalid,
> rather than just useless. You could argue that ROLLBACK TO SAVEPOINT
> should throw an error because no savepoint name is valid in that
> context.
-1 from me. I don't see this as a step forward in any way. The
output is a complete muddle, and it's not solving any problem that I
can see.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2013-11-19 18:12:20 | Re: -d option for pg_isready is broken |
| Previous Message | Fujii Masao | 2013-11-19 18:10:04 | Re: -d option for pg_isready is broken |