| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Kevin Grittner <kgrittn(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Ants Aasma <ants(dot)aasma(at)eesti(dot)ee>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Kevin Grittner <kgrittn(at)postgresql(dot)org>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "pgsql-committers(at)postgresql(dot)org" <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Re: pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold < |
| Date: | 2016-06-10 15:26:23 |
| Message-ID: | CA+TgmoZuQnhFRWQVDyV3EjEEr0K=6FPZzP2q3171ZySSahbzFA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Fri, Jun 10, 2016 at 10:45 AM, Kevin Grittner <kgrittn(at)gmail(dot)com> wrote:
> On Thu, Jun 9, 2016 at 6:16 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
>> So I like the idea of centralizing checks in
>> RelationAllowsEarlyVacuum, but shouldn't it really be called
>> RelationAllowsEarlyPruning?
>
> Since vacuum calls the pruning function, and not the other way
> around, the name you suggest would be technically more correct.
> Committed using "Pruning" instead of "Vacuum" in both new macros.
>
> I have closed the CREATE INDEX versus "snapshot too old" issue in
> the "PostgreSQL 9.6 Open Items" Wiki page.
You've still got an early_vacuum_enabled variable name floating around there.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kevin Grittner | 2016-06-10 16:26:03 | pgsql: Rename local variable for consistency. |
| Previous Message | Robert Haas | 2016-06-10 15:01:25 | pgsql: Update pgstattuple extension for parallel query. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-06-10 15:27:53 | Re: Hard to maintain duplication in contain_volatile_functions_not_nextval_walker |
| Previous Message | Tom Lane | 2016-06-10 15:12:46 | Re: Hard to maintain duplication in contain_volatile_functions_not_nextval_walker |