Re: Missing comment block at the top of streamutil.h and receivelog.h

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Missing comment block at the top of streamutil.h and receivelog.h
Date: 2014-08-26 21:03:12
Message-ID: CA+TgmoZtpFTeaZct19_qvdoDrbsyw4axc-HJGA4oSiNTgy3OrQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Aug 23, 2014 at 11:59 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> As mentioned in $subject, the header files in src/bin/pg_basebackup do
> not have a comment block at the top and do not have any copyright
> text.
> Any reason for that? Shouldn't we have something for consistency with
> the other files like in the patch attached?

Probably that's a good idea, but do we really need Author: tags? I
know we have those in a few places, but certainly not everywhere, and
as time goes by they tend to be less accurate reflections of who wrote
the latest code (as opposed to the original code). Furthermore, every
time we include them, it tends to increase the demand to add even more
of them because, hey, everybody likes to be acknowledged.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2014-08-26 21:10:18 Re: Missing comment block at the top of streamutil.h and receivelog.h
Previous Message Peter Eisentraut 2014-08-26 20:59:11 Re: proposal: rounding up time value less than its unit.