| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Alexey Lesovsky <lesovsky(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Skipping logical replication transactions on subscriber side |
| Date: | 2022-06-23 13:58:07 |
| Message-ID: | CA+TgmoZtD04p3m0AmUGpqCAUQQhKNzbM19_518i8Lndjcx+DjA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 22, 2022 at 10:48 PM Noah Misch <noah(at)leadboat(dot)com> wrote:
> Here's a more-verbose description of (2), with additions about what it does
> and doesn't achieve:
>
> 2. On systems where double alignment differs from int64 alignment, require
> NAMEDATALEN%8==0. Modify the test from commits 79b716c and c1da0ac to stop
> treating "name" fields specially. The test will still fail for AIX
> compatibility violations, but "name" columns no longer limit your field
> position candidates like they do today (today == option (1)). Upgrading to
> v16 would require dump/reload for AIX users changing NAMEDATALEN to conform
> to the new restriction. (I'm not sure pg_upgrade checks NAMEDATALEN
> compatibility, but it should require at least one of: same NAMEDATALEN, or
> absence of "name" columns in user tables.)
Doing this much seems pretty close to free to me. I doubt anyone
really cares about using a NAMEDATALEN value that is not a multiple of
8 on any platform. I also think there are few people who care about
AIX. The intersection must be very small indeed, or so I would think.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-06-23 14:06:12 | Re: WIP Patch: Add a function that returns binary JSONB as a bytea |
| Previous Message | Nikita Malakhov | 2022-06-23 13:53:47 | Re: Pluggable toaster |