Re: A typo in error message

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Alexander Lakhin <exclusion(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: A typo in error message
Date: 2018-01-31 21:47:03
Message-ID: CA+TgmoZrpOcB3v4Hg8t4QgFaqYhtu=pjLo-Bnivzan5L6tVnXA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jan 31, 2018 at 12:53 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Wed, Jan 31, 2018 at 08:47:57AM +0300, Alexander Lakhin wrote:
>> Please consider committing the attached patch to fix a typo in error
>> message.
>
> Yeah..

Committed.

>> if (cxt->ofType)
>> ereport(ERROR,
>> (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
>> - errmsg("identity colums are not supported on typed tables")));
>> + errmsg("identity columns are not supported on typed tables")));
>> if (cxt->partbound)
>> ereport(ERROR,
>> (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
>
> The indentation for this ereport() is weird as well here.

Hit it with pgindent to fix this, too.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2018-01-31 21:51:14 Re: WINDOW RANGE patch versus leakproofness
Previous Message Robert Haas 2018-01-31 21:36:44 Re: Documentation of pgcrypto AES key sizes