| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Subject: | Re: wrong fds used for refilenodes after pg_upgrade relfilenode changes Reply-To: |
| Date: | 2022-05-13 15:33:08 |
| Message-ID: | CA+TgmoZroXYsmfnxcxVAxDZBM7yHiQ0Lhv4YqRL=iti5pULjDw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, May 12, 2022 at 10:20 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> As for skink failing, the timeout was hard coded 300s for the whole
> test, but apparently that wasn't enough under valgrind. Let's use the
> standard PostgreSQL::Test::Utils::timeout_default (180s usually), but
> reset it for each query we send.
@@ -202,6 +198,9 @@ sub send_query_and_wait
my ($psql, $query, $untl) = @_;
my $ret;
+ $psql_timeout->reset();
+ $psql_timeout->start();
+
# send query
$$psql{stdin} .= $query;
$$psql{stdin} .= "\n";
This seems fine, but I think you should add a non-trivial comment about it.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2022-05-13 15:35:31 | Re: make MaxBackends available in _PG_init |
| Previous Message | 'Bruce Momjian' | 2022-05-13 15:06:40 | Re: First draft of the PG 15 release notes |