| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Peter Geoghegan <pg(at)heroku(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Bug in batch tuplesort memory CLUSTER case (9.6 only) |
| Date: | 2016-07-02 22:17:06 |
| Message-ID: | CA+TgmoZrHbtAX+vMdbb1FG5p7N-8wy0Ty09_0v_2Sga+fcwStA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 1, 2016 at 11:37 PM, Noah Misch <noah(at)leadboat(dot)com> wrote:
> I don't know, either. You read both Robert and me indicating that this bug
> fix will be better with a test, and nobody has said that a test-free fix is
> optimal. Here's your chance to obliterate that no-tests precedent.
In the interest of clarity, I was not intending to say that there
should be a regression test in the patch. I was intending to say that
there should be a test case with the bug report. I'm not opposed to
adding a regression test, and I like the idea of attempting to do so
while requiring only a relatively small amount of data by changing
maintenance_work_mem, but that wasn't the target at which I was
aiming. Nevertheless, carry on.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-07-02 22:32:41 | Re: Password identifiers, protocol aging and SCRAM protocol |
| Previous Message | Robert Haas | 2016-07-02 22:10:02 | Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold < |