From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com> |
Cc: | Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: BUG: pg_dump generates corrupted gzip file in Windows |
Date: | 2017-03-24 16:46:56 |
Message-ID: | CA+TgmoZoP-HTHh9Qd5ngDCJ9-AxoauLvPDyCCbg=WgzuYoEUsg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Mar 24, 2017 at 6:44 AM, Kuntal Ghosh
<kuntalghosh(dot)2007(at)gmail(dot)com> wrote:
>> ASAICU, if we use binary mode, output is stored bit by bit. In ASCII
>> mode, cmd pokes its nose and does CR / LF conversions on its own. So,
>> whenever we want compression on a plain-text dump file, we can set the
>> stdout mode to O_BINARY. Is it a wrong approach?
> With the help from Ashutosh Sharma, I tested this in Windows
> environment. Sadly, it still doesn't work. :( IMHO, we should document
> the issue somewhere.
Why not? I mean, if there's code there to force the output into
binary mode, does that not work for the -Fc case? And if it does work
for the -Fc case, then why doesn't it also work for -Z9?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Ashutosh Sharma | 2017-03-24 16:51:53 | Re: Supporting huge pages on Windows |
Previous Message | Dave Page | 2017-03-24 16:46:12 | Re: Monitoring roles patch |