Re: upgrades in row-level locks can deadlock

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Oleksii Kliukin <alexk(at)hintbits(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: upgrades in row-level locks can deadlock
Date: 2019-06-13 17:32:49
Message-ID: CA+TgmoZnHK0B3LzH9o1MtGnku5G2uEiyHfc7LCzNET4JoLrvfQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jun 12, 2019 at 12:47 PM Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> Please don't simplify the table name to just "t" -- the reason I used
> another name is that we want these tests to be able to run concurrently
> at some point; ref.
> https://postgr.es/m/20180124231006.z7spaz5gkzbdvob5@alvherre.pgsql

Not only that, but 't' is completely ungreppable. If you name the
table 'walrus' and five years from now somebody sees an error about it
in some buildfarm log or whatever, they can type 'git grep walrus' to
find the test, and they'll probably only get that one hit. If you
name it 't', well...

[rhaas pgsql]$ git grep t | wc -l
1653468

Not very helpful.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2019-06-13 17:37:45 Re: Multivariate MCV stats can leak data to unprivileged users
Previous Message Tom Lane 2019-06-13 17:22:16 Re: release notes: tids & self-joins