Re: pg_regress not waiting for postmaster to stop

On Fri, Jun 19, 2015 at 2:33 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> In pg_regress.c, there is the following code:
> static void
> stop_postmaster(void)
> {
> if (postmaster_running)
> {
> /* We use pg_ctl to issue the kill and wait for stop */
> char buf[MAXPGPATH * 2];
> int r;
>
> /* On Windows, system() seems not to force fflush, so... */
> fflush(stdout);
> fflush(stderr);
>
> snprintf(buf, sizeof(buf),
> "\"%s%spg_ctl\" stop -D \"%s/data\"
> -w -s -m fast",
> bindir ? bindir : "",
> bindir ? "/" : "",
> temp_instance);
>
> Except if I am missing something, the comment mentions that we should
> wait for the stop but there is no -w switch in the command of pg_ctl.
> Doesn't the patch attached make sense?

Do we need to wait, or is failing to wait harmless?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company