| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: xlog.c: removing ReadRecPtr and EndRecPtr |
| Date: | 2021-11-24 16:37:28 |
| Message-ID: | CA+TgmoZmoZ7R4c2yELcD0ME604d0xN2WbsFESzfL-EmDqB8VqQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 23, 2021 at 1:36 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> Attached please find the test case not for commit as
> v2-0001-dubious-test-case.patch; the fix, for commit and now with a
> proper commit message as
> v2-0002-Fix-corner-case-failure-to-detect-improper-timeli.patch; and
> the back-ported test case for v14 as v14-0001-dubious-test-case.patch
> in case anyone wants to play around with that. (with apologies for
> using the idea of a version number in two different and conflicting
> senses)
OK, I have committed this patch, rebased the original combined patch
over top of that, and committed that too. By my count that means I've
now removed a total of 3 global variables from this file and Amul got
rid of one as well so that makes 4 in total. If we continue at this
brisk pace the code may become understandable and maintainable
sometime prior to the heat death of the universe, which I think would
be rather nice.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2021-11-24 16:38:53 | Re: Minor documentation fix - missing blank space |
| Previous Message | Robert Haas | 2021-11-24 16:27:58 | pgsql: xlog.c: Remove global variables ReadRecPtr and EndRecPtr. |