From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Declarative partitioning - another take |
Date: | 2016-08-16 18:54:52 |
Message-ID: | CA+TgmoZme6WW19_XOtz5_e3TBJhAJFWAZ9U4yEwJuFNUxGby2A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Aug 10, 2016 at 7:09 AM, Amit Langote
<Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> 0002-psql-and-pg_dump-support-for-partitioned-tables.patch
+ if (pset.sversion >= 90600 && tableinfo.relkind == 'P')
Version check is redundant, right?
+) PARTITION BY RANGE ((a+b));
+\d describe_range_key
+Partitioned table "public.describe_range_key"
+ Column | Type | Modifiers
+--------+---------+-----------
+ a | integer |
+ b | integer |
+Partition Key: PARTITION BY RANGE (((a + b)))
I understand that it's probably difficult not to end up with two sets
of parentheses here, but can we avoid ending up with three sets?
Also, I wonder if pg_get_partkeydef() should omit "PARTITION BY" and
pg_dump can add that part back. Then this could say:
Partition Key: RANGE ((a + b))
...which seems a good deal more natural than what you have now.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2016-08-16 19:03:16 | Re: Intermittent "cache lookup failed for type" buildfarm failures |
Previous Message | Tom Lane | 2016-08-16 18:49:13 | Re: Intermittent "cache lookup failed for type" buildfarm failures |