Re: The pgrminclude problem

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Peter Geoghegan <peter(at)2ndquadrant(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: The pgrminclude problem
Date: 2012-08-20 19:22:04
Message-ID: CA+TgmoZm3dKHCWmvfDVwj6B6zkDYWRNSXUDR_7=+zrbTEvhMJQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Aug 20, 2012 at 12:03 PM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> Excerpts from Robert Haas's message of lun ago 20 11:43:44 -0400 2012:
>> I actually think we'd probably be better off running pgrminclude once
>> per release cycle rather than any less often. When the number of
>> changes gets into the hundreds or thousands of lines it becomes much
>> more difficult to validate that it's doing anything sensible. I ran
>> it a while back and found a bunch of stuff that looked like it was
>> obviously worth fixing, but I was afraid of getting yelled at if I
>> went and fixed it, so I didn't. Somehow that doesn't seem like an
>> ideal situation...
>
> Alternatively you could post a patch for comment.

Yeah, maybe I'll try that if I get back around to working on this at some point.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2012-08-20 19:32:45 Re: sha1, sha2 functions into core?
Previous Message Robert Haas 2012-08-20 19:19:59 Re: Large number of open(2) calls with bulk INSERT into empty table