From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: CONNECTION LIMIT and Parallel Query don't play well together |
Date: | 2017-01-26 14:53:35 |
Message-ID: | CA+TgmoZh4uEbK+b5MMivJ-UnbycB4rv+ZhY8x4CDEem9GiN-ug@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Jan 26, 2017 at 7:59 AM, David Rowley
<david(dot)rowley(at)2ndquadrant(dot)com> wrote:
> On 12 January 2017 at 15:24, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> wrote:
>> I've attached a patch which intended to assist discussions on this topic.
>>
>> The patch adds some notes to the docs to mention that background
>> workers and prepared xacts are not counted in CONNECTION LIMIT, it
>> then goes on and makes CountUserBackends() ignore bgworkers. It was
>> already ignoring prepared xacts. There's a bit of plumbing work to
>> make the proc array aware of the background worker status. Hopefully
>> this is suitable. I'm not all that close to that particular area of
>> the code.
>
> Wondering you've had any time to glance over this?
>
> If you think the patch needs more work, or goes about things the wrong
> way, let me know, and I'll make the changes.
Sorry, this had slipped through the cracks -- I'm having a very hard
time keeping up with the flow of patches and emails. But it looks
good to me, except that it seems like CountDBBackends() needs the same
fix (and probably a corresponding documentation update).
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2017-01-26 15:02:34 | Re: Assignment of valid collation for SET operations on queries with UNKNOWN types. |
Previous Message | Joshua D. Drake | 2017-01-26 14:52:11 | Re: Checksums by default? |