| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Recursively fsync() the data directory after a crash. |
| Date: | 2015-05-05 13:17:07 |
| Message-ID: | CA+TgmoZgU7phQDPP7jm6gQ3N5u67Vp7FLiJ56M6dv9TD_+W97w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Mon, May 4, 2015 at 11:37 PM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> On 05/04/2015 02:23 PM, Robert Haas wrote:
>> Recursively fsync() the data directory after a crash.
>>
>> Otherwise, if there's another crash, some writes from after the first
>> crash might make it to disk while writes from before the crash fail
>> to make it to disk. This could lead to data corruption.
>>
>> Back-patch to all supported versions.
>>
>
> This appears to have broken Windows builds. At least it's broken by using
> the two argument form of open instead of the three argument form, for which
> we have a #define in the win32 case, and pg_win32_is_junction is a typo -
> the first _ should not be there.
Sorry about that. Working on it now.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2015-05-05 13:30:19 | pgsql: Fix some problems with patch to fsync the data directory. |
| Previous Message | Andrew Dunstan | 2015-05-05 03:37:21 | Re: pgsql: Recursively fsync() the data directory after a crash. |