| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Ian Lawrence Barwick <barwick(at)gmail(dot)com> |
| Cc: | Dong Wook Lee <sh95119(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pg_basebackup: add test about zstd compress option |
| Date: | 2022-12-05 14:59:45 |
| Message-ID: | CA+TgmoZgSqV0FkvHchZpajX1N1n=E92doV3kQST-miEzJNuDNA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Dec 2, 2022 at 11:29 PM Ian Lawrence Barwick <barwick(at)gmail(dot)com> wrote:
> Though on reflection maybe it's overkill and the existing tests
> suffice. Anyway leaving the patch here in the interests of pushing
> this forward in some direction.
Do you think that there is a scenario where 008_untar.pl and
009_extract.pl pass but this test fails, alerting us to a problem that
would otherwise have gone undetected? If so, what is that scenario?
The only thing that I can think of would be if $decompress_program
--test were failing, but actually trying to decompress succeeded. I
would be inclined to dismiss that particular scenario as not important
enough to be worth the additional CPU cycles.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2022-12-05 15:08:57 | Re: pg_dump: Remove "blob" terminology |
| Previous Message | Vik Fearing | 2022-12-05 14:57:13 | ANY_VALUE aggregate |