Re: fix the spelling mistakes of comments

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, "Liu, Huailing" <liuhuailing(at)cn(dot)fujitsu(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: fix the spelling mistakes of comments
Date: 2019-04-05 19:48:32
Message-ID: CA+TgmoZg0GdmMzZVWpHM4vpsB1pSOCuaNFVZRYgT1-jt08vr1w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Apr 4, 2019 at 11:55 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Indeed.
>
> Well, the problem is the lack of grammatical agreement between "waiting"
> and "release". It's poor English at least.

It's not correct for formal writing, but I think a lot of people would
find it acceptable in casual speech. At any rate, the proposed change
to "This module contains the code for waiting and releasing of
backends" is no better, because it's still faulty parallelism. You
can release a backend, but you can't "wait" a backend. If you want to
make it really good English, you're going to have to change more than
one word. (e.g. "This module contains the code to make backends wait
for replication, and to release them from waiting at the appropriate
time.")

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2019-04-05 19:57:33 Re: "WIP: Data at rest encryption" patch and, PostgreSQL 11-beta3
Previous Message Arthur Zakirov 2019-04-05 19:35:51 Re: [PROPOSAL] Shared Ispell dictionaries