| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | David Steele <david(at)pgmasters(dot)net> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PATCH: Make pg_stop_backup() archive wait optional |
| Date: | 2017-03-06 17:48:40 |
| Message-ID: | CA+TgmoZfjF2k6N8Rfga20bXxnRAttuz8N6dvxeOu=t3j0FYYsg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Mar 4, 2017 at 9:12 AM, David Steele <david(at)pgmasters(dot)net> wrote:
> Yes, that makes sense. Attached are two patches as requested:
>
> 01 - Just marks pg_stop_backup() variants as parallel restricted
> 02 - Add the wait_for_archive param to pg_stop_backup().
>
> These apply cleanly on 272adf4.
Committed 01. Nobody's offered an opinion about 02 yet, so I'm not
going to commit that, but one minor nitpick:
+ WAL to be archived. This behavior is only useful for backup
+ software which independently monitors WAL archiving, otherwise WAL
+ required to make the backup consistent might be missing and make the backup
I think this should really say "...which independently monitors WAL
archiving. Otherwise, WAL..."
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2017-03-06 17:53:13 | Re: PATCH: Make pg_stop_backup() archive wait optional |
| Previous Message | Andres Freund | 2017-03-06 17:44:06 | Re: PATCH: two slab-like memory allocators |