| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Removing xloginsert_slots? |
| Date: | 2014-01-29 19:51:38 |
| Message-ID: | CA+TgmoZbe7qCc_4S9OUpRa9LhQiG5j7PzakWKtCDgY-XtqOLRg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 29, 2014 at 8:22 AM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> Hi,
>
> On 2014-01-29 21:59:05 +0900, Michael Paquier wrote:
>> The undocumented GUC called xloginsert_slots has been introduced by
>> commit 9a20a9b. It is mentioned by the commit that this parameter
>> should be removed before the release. Wouldn't it be a good time to
>> remove this parameter soon? I imagine that removing it before the beta
>> would make sense so now is perhaps too early... Either way, attached
>> is a patch doing so...
>
> I'd rather wait till somebody actually has done some benchmarks. I don't
> think we're more clueful about it now than back when the patch went
> in. And such benchmarking is more likely during beta, so...
Well, it's either got to go away, or get documented, IMHO.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2014-01-29 19:54:26 | Re: ALTER TABLE lock strength reduction patch is unsafe |
| Previous Message | Robert Haas | 2014-01-29 19:50:29 | Re: Add force option to dropdb |