| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Shouldn't CREATE TABLE LIKE copy the relhasoids property? |
| Date: | 2015-04-21 21:36:41 |
| Message-ID: | CA+TgmoZa3AVDK5WW2yRiD0VgmrrvEZPjMTrsRBb87XNNDTsxuw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Apr 20, 2015 at 5:41 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> On Mon, Apr 20, 2015 at 05:04:14PM -0400, Robert Haas wrote:
>> On Mon, Apr 20, 2015 at 4:11 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>> > Slightly improved patch applied.
>>
>> Is it?
>
> The patch has a slightly modified 'if' statement to check a constant
> before calling a function, and use elseif:
>
> < + if (!interpretOidsOption(stmt->options, true) && cxt.hasoids)
> ---
> > + if (cxt.hasoids && !interpretOidsOption(stmt->options, true))
> 47c57
> < + if (interpretOidsOption(stmt->options, true) && !cxt.hasoids)
> ---
> > + else if (!cxt.hasoids && interpretOidsOption(stmt->options, true))
>
> I realize the change is subtle.
What I meant was - I didn't see an attachment on that message.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2015-04-21 21:42:28 | Re: Streaming replication and WAL archive interactions |
| Previous Message | Merlin Moncure | 2015-04-21 21:30:39 | Re: Reducing spinlock acquisition within clock sweep loop |