| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com> |
| Subject: | Re: [PATCH] Transaction traceability - txid_status(bigint) |
| Date: | 2016-08-29 06:01:32 |
| Message-ID: | CA+TgmoZ_Y1sPXZ1U-AoTzAL0AVHu0H8yT_M9-Mx-RYATAV5N+A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Aug 28, 2016 at 11:25 PM, Craig Ringer <craig(at)2ndquadrant(dot)com> wrote:
> What I'd really like is to be able to ask transam.c to handle the
> xid_in_recent_past logic, treating an attempt to read an xid from
> beyond the clog truncation threshold as a soft error indicating
> unknown xact state. But that involves delving into slru.c, and I
> really, really don't want to touch that for what should be a simple
> and pretty noninvasive utility function.
I think you're going to have to bite the bullet and do that, though, because ...
> A PG_TRY to trap ERRCODE_UNDEFINED_FILE seems like it'd be sufficient,
...I don't think this has any chance of being acceptable. You can't
catch errors and not re-throw them. That's bad news.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Borodin | 2016-08-29 06:04:49 | GiST penalty functions [PoC] |
| Previous Message | Craig Ringer | 2016-08-29 05:36:43 | Re: Renaming of pg_xlog and pg_clog |