| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Make pgbench use erand48() rather than random(). |
| Date: | 2011-08-03 23:08:32 |
| Message-ID: | CA+TgmoZ_PHpOQ6B+L9CYXzfBzvXr4kX9zBt=_fXFvk1S3UW6MA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Wed, Aug 3, 2011 at 6:36 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I do however notice a vestigial reference to MAX_RANDOM_VALUE at line
> 1063, which we probably should get rid of. What I think we probably
> need instead, and don't have, is a check that "max - min + 1" doesn't
> overflow.
Seems reasonable. Do you want to take care of that, or shall I do it?
Off-hand, the easiest approach seems to be to define SAMESIGN in
pgbench.c using the same definition we employ in various other places,
and then copy the test we use in int4pl().
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2011-08-04 16:07:15 | pgsql: In documentaiton, clarify which commands have reduced WAL volume |
| Previous Message | Tom Lane | 2011-08-03 22:36:56 | Re: pgsql: Make pgbench use erand48() rather than random(). |