| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Noah Misch <noah(at)leadboat(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, samay sharma <smilingsamay(at)gmail(dot)com>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
| Subject: | Re: Inconsistencies around defining FRONTEND |
| Date: | 2022-08-23 21:24:30 |
| Message-ID: | CA+TgmoZZ3n5-RB83e8oC7BJW9DuGSCXe+1cB0ApqNV80FZqkbw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Aug 20, 2022 at 3:46 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> Unfortunately, the remaining uses of FRONTEND are required. That's:
> - pg_controldata, via #define
> - pg_resetwal, via #define
> - pg_rewind, via -DFRONTEND, due to xlogreader.c
> - pg_waldump, via #define and -DFRONTEND, due to xlogreader.c, xlogstats.c, rmgrdesc/*desc.c
Actually, I think we could fix these pretty easily too. See attached.
This has been annoying me for a while. I hope we can agree on a way to
clean it up.
--
Robert Haas
EDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Remove-define-FRONTEND-hacks.patch | application/octet-stream | 17.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nikita Glukhov | 2022-08-23 21:29:00 | Re: SQL/JSON features for v15 |
| Previous Message | Tom Lane | 2022-08-23 21:06:00 | Re: Move NON_EXEC_STATIC from c.h |