| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Fabrízio Mello <fabriziomello(at)gmail(dot)com>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Proposal : REINDEX xxx VERBOSE |
| Date: | 2015-05-13 15:28:03 |
| Message-ID: | CA+TgmoZX7UAGJjKAUDSUjpnWKXB3qeGD6GUMyUC2jVoh6DRMpw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, May 7, 2015 at 6:55 PM, Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com> wrote:
> Sorry, I forgot attach files.
Review comments:
- Customarily we use int, rather than uint8, for flags variables. I
think we should do that here also.
- reindex_index() emits a log message either way, but at DEBUG2 level
without VERBOSE and at the INFO level with it. I think we should skip
it altogether without VERBOSE. i.e. if (options & REINDEXOPT_VERBOSE)
ereport(...)
- The errmsg() in that function should not end with a period.
- The 000 patch makes a pointless whitespace change to tab-complete.c.
- Instead of an enumerated type (ReindexOption) just use #define to
define the flag value.
Apart from those fairly minor issues, I think this looks pretty solid.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-05-13 15:38:27 | Triaging the remaining open commitfest items |
| Previous Message | Bruce Momjian | 2015-05-13 15:19:29 | Re: a few thoughts on the schedule |