From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Peter Geoghegan <pg(at)heroku(dot)com> |
Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: More work on SortSupport for text - strcoll() and strxfrm() caching |
Date: | 2015-10-06 20:16:12 |
Message-ID: | CA+TgmoZWTM2_QMbwPLq-dDcLvBYMO6ay3Qawrn9+K=bheELK9A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Oct 6, 2015 at 4:09 PM, Peter Geoghegan <pg(at)heroku(dot)com> wrote:
> On Tue, Oct 6, 2015 at 1:07 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> Reviewing 0001, I'm happy to see us add bswap64, but I'm not sure we
>> should put it in c.h, because that's included by absolutely
>> everything. How about putting it in a new #include inside src/port,
>> like src/port/pg_bswap.h? Then pg_crc.h can include that, but other
>> things can, too.
>
> I guess I imagined that bswap64() was fundamental infrastructure, but
> on second thought that's not actually in evidence -- it is not already
> needed in plenty of other places. So yeah, works for me.
If you would care to revise the patch accordingly, I will commit it
(barring objections from others, of course).
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Geoghegan | 2015-10-06 20:26:09 | Re: More work on SortSupport for text - strcoll() and strxfrm() caching |
Previous Message | Robert Haas | 2015-10-06 20:15:29 | Re: SortSupport for UUID type |