| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Sergei Kornilov <sk(at)zsrv(dot)org> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net>, Ildar Musin <i(dot)musin(at)postgrespro(dot)ru> |
| Subject: | Re: using index or check in ALTER TABLE SET NOT NULL |
| Date: | 2019-03-13 16:20:30 |
| Message-ID: | CA+TgmoZWSLUjVcc9KBSVvbn=U5QRgW1O-MgUX0y5CnLZOA2qyQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 13, 2019 at 11:17 AM Sergei Kornilov <sk(at)zsrv(dot)org> wrote:
> > The buildfarm thinks additional nitpicking is needed.
>
> hm. Patch was committed with debug1 level tests and many animals uses log_statement = 'all'. Therefore they have additional line in result: LOG: statement: alter table pg_class alter column relname drop not null; and similar for other queries.
> I think we better would be to revert "set client_min_messages to 'debug1';" part.
Ugh, I guess so. Or how about changing the message itself to use
INFO, like we already do in QueuePartitionConstraintValidation?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey Borodin | 2019-03-13 16:32:40 | Re: Compressed TOAST Slicing |
| Previous Message | Robert Haas | 2019-03-13 16:13:46 | hyrax vs. RelationBuildPartitionDesc |