| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, David Zhang <david(dot)zhang(at)highgo(dot)ca>, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Avoid unecessary MemSet call (src/backend/utils/cache/relcache.c) |
| Date: | 2022-08-24 19:19:35 |
| Message-ID: | CA+TgmoZWFQCkWWdrnjf3n-N_N8-gxccjPKKqekEZahAfTnJ+Ag@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Aug 24, 2022 at 3:00 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Call me a trogdolyte, but I don't follow how it's an improvement.
> It looks to me like an entirely random change that doesn't get rid
> of assumptions about what the bits are, it just replaces one set of
> assumptions with a different set. Moreover, the new set of assumptions
> may include "there are no padding bits in here", which is mighty fragile
> and hard to verify. So I frankly do not find this a stylistic improvement.
Ditto.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ranier Vilela | 2022-08-24 19:20:15 | Re: Avoid unecessary MemSet call (src/backend/utils/cache/relcache.c) |
| Previous Message | Tom Lane | 2022-08-24 19:00:10 | Re: Avoid unecessary MemSet call (src/backend/utils/cache/relcache.c) |