From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Joe Van Dyk <joe(at)tanga(dot)com>, "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org> |
Subject: | Re: ltree::text not immutable? |
Date: | 2014-11-06 01:38:36 |
Message-ID: | CA+TgmoZUTHRR2DE3pmG0to12LH5XoXBGXBw2wnFd6DN2r_xU+Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
On Tue, Nov 4, 2014 at 6:48 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I wrote:
>> An alternative that just occurred to me is to put the no-volatile-
>> I/O-functions check into CREATE TYPE, but make it just WARNING not
>> ERROR. That would be nearly as good as an ERROR in terms of nudging
>> people who'd accidentally omitted a volatility marking from their
>> custom types. But we could leave chkpass as-is and wait to see if
>> anyone complains "hey, why am I getting this warning?". If we don't
>> hear anyone complaining, maybe that means we can get away with changing
>> the type's behavior in 9.6 or later.
>
> Attached is a complete patch along these lines. As I suggested earlier,
> this just makes the relevant changes in ltree--1.0.sql and
> pg_trgm--1.1.sql without bumping their extension version numbers,
> since it doesn't seem important enough to justify a version bump.
>
> I propose that we could back-patch the immutability-additions in ltree and
> pg_trgm, since they won't hurt anything and might make life a little
> easier for future adopters of those modules. The WARNING additions should
> only go into HEAD though.
I don't understand why you went to all the trouble of building a
versioning system for extensions if you're not going to use it.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2014-11-06 07:34:51 | Re: BUG #11883: Year 1500 not treated as leap year when it was a leap year |
Previous Message | Tom Lane | 2014-11-06 00:10:00 | Re: BUG #11884: pg_dump / restore mangles IS DISTINCT FROM expressions |
From | Date | Subject | |
---|---|---|---|
Next Message | Josh Berkus | 2014-11-06 01:39:30 | Re: recovery_target_time and standby_mode |
Previous Message | Peter Geoghegan | 2014-11-06 01:30:43 | Re: B-Tree index builds, CLUSTER, and sortsupport |