| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andreas Karlsson <andreas(at)proxel(dot)se> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Greg Stark <stark(at)mit(dot)edu>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Planning time in explain/explain analyze |
| Date: | 2014-01-29 21:10:02 |
| Message-ID: | CA+TgmoZSG8kiYM54TVrjZb2-uBm7Kix+Qb+cPYvvPvJKidw5hA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 29, 2014 at 3:13 PM, Andreas Karlsson <andreas(at)proxel(dot)se> wrote:
> On 01/29/2014 09:01 PM, Robert Haas wrote:
>> Cool. I propose adding one parameter rather than two to
>> ExplainOnePlan() and making it of type instr_time * rather than
>> passing an instr_time and a bool. If you don't want to include the
>> planning time, pass NULL; if you do, pass a pointer to the instr_time
>> you want to print. I think that would come out slightly neater than
>> what you have here.
>
> Excellent suggestion, thanks! New patch attached.
Committed with minor doc changes.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2014-01-29 21:14:02 | Re: Add min and max execute statement time in pg_stat_statement |
| Previous Message | Robert Haas | 2014-01-29 21:10:00 | pgsql: Include planning time in EXPLAIN ANALYZE output. |