Re: pgsql: Don't try to print data type names in slot_store_error_callback(

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Don't try to print data type names in slot_store_error_callback(
Date: 2021-07-08 14:57:22
Message-ID: CA+TgmoZSFZ1x02ndWSF2b__t4OjY2oBVmp+WPs4m85d-g_ooNw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Fri, Jul 2, 2021 at 4:05 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> The existing code tried to do syscache lookups in an already-failed
> transaction, which is problematic to say the least.

Why didn't the assertion in SearchCatCacheInternal() catch this? Was
this code never actually tested?

--
Robert Haas
EDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2021-07-08 15:21:48 Re: pgsql: Don't try to print data type names in slot_store_error_callback(
Previous Message Daniel Gustafsson 2021-07-08 10:56:29 pgsql: Fix typos in pgstat.c, reorderbuffer.c and pathnodes.h

Browse pgsql-hackers by date

  From Date Subject
Next Message Boris Kolpackov 2021-07-08 15:07:44 Re: Pipeline mode and PQpipelineSync()
Previous Message Hannu Krosing 2021-07-08 14:46:51 Re: pgbench logging broken by time logic changes