Re: Use log_newpage_range in HASH index build

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: lakshmi <lakshmigcdac(at)gmail(dot)com>
Cc: Kirill Reshke <reshkekirill(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Use log_newpage_range in HASH index build
Date: 2026-04-26 17:12:06
Message-ID: CA+TgmoZRs3ArQC_rkVCx_Q7rWCM+QF-Q6ERRYUaN4tUvr+rd7w@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jan 5, 2026 at 3:48 AM lakshmi <lakshmigcdac(at)gmail(dot)com> wrote:
> Following up on my earlier note, I implemented the proposed HASH overflow page reuse enhancement.Recently freed overflow pages are recorded in
> _hash_freeovflpage( ),and _hash_addovflpage( ) now prefers reusing those pages during allocation before falling back to the bitmap scan.
>
> The change is backend-local and allocation-only,with no WAL or on-disk format changes.I verified correctness using index build/drop and VACUUM cycles,and confirmed WAL neutrality by comparing WAL generated during HASH index builds with and without this change (no observable difference beyond normal noise).
>
> The patch is attached for review.Feedback is welcome.

It is probably best to start a separate email thread specifically
about this patch, because it's doing something quite different from
the original patch. I suggest presenting some specific performance
results, as it's not very clear how much benefit this might have. It
might be good to test a favorable scenario and also an unfavorable
scenario, describing and showing results for each.

--
Robert Haas
EDB: http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2026-04-26 21:32:52 Separators in pg_hosts.conf fields
Previous Message Robert Haas 2026-04-26 17:09:32 Re: Use log_newpage_range in HASH index build