| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Relation bulk write facility |
| Date: | 2024-01-10 16:17:22 |
| Message-ID: | CA+TgmoZR21bmTNjoKgAB=9AwncyNSU1QTtDJJsVo0MAYakyiOQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Nov 24, 2023 at 10:22 PM Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
> Yeah, I'm not very happy with this interface. The model is that you get
> a buffer to write to by calling bulkw_alloc_buf(). Later, you hand it
> over to bulkw_write(), which takes ownership of it and frees it later.
> There is no other function to free it, although currently the buffer is
> just palloc'd so you could call pfree on it.
I think we should try to pick prefixes that are one or more words
rather than using word fragments. bulkw is an awkward prefix even for
people whose first language is English, and probably more awkward for
others.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bertrand Drouvot | 2024-01-10 16:32:36 | Re: Test slots invalidations in 035_standby_logical_decoding.pl only if dead rows are removed |
| Previous Message | Robert Haas | 2024-01-10 16:13:10 | Re: the s_lock_stuck on perform_spin_delay |