| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com> |
| Cc: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Subject: | Re: [HACKERS] UPDATE of partition key |
| Date: | 2018-01-19 20:36:14 |
| Message-ID: | CA+TgmoZQKJPYxWfCBtkk9HG2eAoAf1mp7VXm_8HV4kxjqMShUQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 19, 2018 at 4:37 AM, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com> wrote:
> Attached rebased patch.
Committed with a bunch of mostly-cosmetic revisions. I removed the
macro you added, which has a multiple evaluation hazard, and just put
that logic back into the function. I don't think it's likely to
matter for performance, and this way is safer. I removed an inline
keyword from another static function as well; better to let the
compiler decide what to do. I rearranged a few things to shorten some
long lines, too. Aside from that I think all of the changes I made
were to comments and documentation.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2018-01-19 20:43:39 | Re: [HACKERS] Refactor handling of database attributes between pg_dump and pg_dumpall |
| Previous Message | Robert Haas | 2018-01-19 20:33:38 | pgsql: Allow UPDATE to move rows between partitions. |