| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Ildus Kurbangaliev <i(dot)kurbangaliev(at)postgrespro(dot)ru> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, "andres(at)anarazel(dot)de" <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Subject: | Re: [PATCH] Refactoring of LWLock tranches |
| Date: | 2015-11-16 23:55:55 |
| Message-ID: | CA+TgmoZOsRY6nHbAbS7KeXymEffNSktLx3pemBO+syMLsW5OXQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 16, 2015 at 7:32 AM, Ildus Kurbangaliev
<i(dot)kurbangaliev(at)postgrespro(dot)ru> wrote:
> What if just create a control struct in shared memory like in other places? BufferDescriptors
> and BufferBlocks can be kept there along with tranches definitions
> and lwlocks. Buffer locks that are located in MainLWLockArray by offset
> can be moved there too.
Yeah, we could do that, but what's the advantage of it? The alignment
of the buffer descriptors is kinda finnicky and matters to
performance, so it seems better not to prefix them with something that
might perturb it. If we just rebase Andres' patch over what I just
committed and add in something so that the buffer numbers are fed from
#defines or an enum instead of being random integers, I think we're
done.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2015-11-17 00:02:14 | Re: Proposing COPY .. WITH PERMISSIVE |
| Previous Message | Robert Haas | 2015-11-16 23:53:12 | Re: [PATCH] Refactoring of LWLock tranches |