Re: per-column FDW options, v5

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Shigeru Hanada <shigeru(dot)hanada(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: per-column FDW options, v5
Date: 2011-08-05 17:25:48
Message-ID: CA+TgmoZNgBgrMKMaG3h_+hSj70ooCUDYbJ5mEssgYRUMHYj7cQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jul 29, 2011 at 10:09 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> 2011/7/29 Shigeru Hanada <shigeru(dot)hanada(at)gmail(dot)com>:
>> Here is a rebased version of per-column FDW options patch.  I've
>> proposed this patch in last CF, but it was marked as returned with
>> feedback.  So I would like to propose in next CF 2011-09.  I already
>> moved CF item into new topic "SQL/MED" of CF 2011-09.
>
> I did a quick review of this patch and it looks good to me, modulo
> some quibbles with the wording of the documentation and comments and a
> couple of minor stylistic nitpicks.  Barring objections, I'll fix this
> up a bit and commit it.

Done.

Incidentally, I notice that if you do:

\d some_foreign_table

...the table-level options are not displayed. We probably ought to do
something about that...

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2011-08-05 17:57:13 Re: Further news on Clang - spurious warnings
Previous Message Robert Haas 2011-08-05 16:12:17 Re: Further news on Clang - spurious warnings