| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Cc: | Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: strange parallel query behavior after OOM crashes |
| Date: | 2017-04-05 13:39:07 |
| Message-ID: | CA+TgmoZKp4cG1ORS6bYMtN52TZkrwYF+3A83D5DYB9v7fezAcw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Apr 4, 2017 at 1:52 PM, Tomas Vondra
<tomas(dot)vondra(at)2ndquadrant(dot)com> wrote:
> In any case, the comment right before BackgroundWorkerArray says this:
>
> * These counters can of course overflow, but it's not important here
> * since the subtraction will still give the right number.
>
> which means that this assert
>
> + Assert(BackgroundWorkerData->parallel_register_count >=
> + BackgroundWorkerData->parallel_terminate_count);
>
> is outright broken, just like any other attempts to rely on simple
> comparisons of these two counters, no?
Yeah, that's busted. Good catch.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-04-05 13:39:37 | Re: Re: Query fails when SRFs are part of FROM clause (Commit id: 69f4b9c85f) |
| Previous Message | Robert Haas | 2017-04-05 13:36:47 | Re: Patch: Write Amplification Reduction Method (WARM) |