Re: Avoid resource leak (src/test/modules/test_binaryheap/test_binaryheap.c)

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Avoid resource leak (src/test/modules/test_binaryheap/test_binaryheap.c)
Date: 2025-09-12 18:57:09
Message-ID: CA+TgmoZKR-CR95rtOVH1eNKy+M-ZvngOyyoM_zQLYbt+70ezvQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Sep 12, 2025 at 1:54 PM Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> wrote:
> Per Coverity.
>
> Coverity reports this resource leak in test_binaryheap module.
> I think that is right.
>
> Trivial patch attached.

If this were correct, we'd need to also free the memory in all the
error paths. But of course, in both error and non-error paths, we rely
on memory context cleanup to free memory for us, except in cases where
there's some specific reason to believe that's not good enough. I
doubt that there is any such reason in this case.

See src/backend/utils/mmgr/README

--
Robert Haas
EDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jonathan S. Katz 2025-09-12 18:59:34 Re: PostgreSQL 18 GA press release draft
Previous Message Chiranmoy.Bhattacharya@fujitsu.com 2025-09-12 18:49:01 Re: [PATCH] Hex-coding optimizations using SVE on ARM.