| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | "andres(at)anarazel(dot)de" <andres(at)anarazel(dot)de> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Vladimir Borodin <root(at)simply(dot)name>, Александр Коротков <aekorotkov(at)gmail(dot)com>, Ildus Kurbangaliev <i(dot)kurbangaliev(at)postgrespro(dot)ru>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: RFC: replace pg_stat_activity.waiting with something more descriptive |
| Date: | 2016-01-27 20:42:16 |
| Message-ID: | CA+TgmoZHLkuMmyJLhTrOQo41REZeDBMbi4=_-bFSMypE3r_vQw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 26, 2016 at 3:10 AM, andres(at)anarazel(dot)de <andres(at)anarazel(dot)de> wrote:
> I do think there's a considerable benefit in improving the
> instrumentation here, but his strikes me as making live more complex for
> more users than it makes it easier. At the very least this should be
> split into two fields (type & what we're actually waiting on). I also
> strongly suspect we shouldn't use in band signaling ("process not
> waiting"), but rather make the field NULL if we're not waiting on
> anything.
+1 for splitting it into two fields.
Regarding making the field NULL, someone (I think you) proposed
previously that we should have one field indicating whether we are
waiting, and a separate field (or two) indicating the current or most
recent wait event. That would be similar to how
pg_stat_activity.{query,state} work.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2016-01-27 20:54:58 | Re: GIN pending list clean up exposure to SQL |
| Previous Message | Robert Haas | 2016-01-27 20:15:17 | Re: Batch update of indexes |