Re: Aggregate Push Down - Performing aggregation on foreign server

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>
Cc: Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Aggregate Push Down - Performing aggregation on foreign server
Date: 2016-10-21 14:08:30
Message-ID: CA+TgmoZH+Eia9T5pVGOow6Q5G-NbMNM3YzAAHLaNUqY3_6y4jw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Oct 20, 2016 at 5:38 AM, Jeevan Chalke
<jeevan(dot)chalke(at)enterprisedb(dot)com> wrote:
> Changes look good to me.
> Thanks for the detailed review.

I didn't find anything structurally wrong with this patch, so I've
committed it with many cosmetic changes. Judging by what happened
with join pushdown, there are probably some residual bugs, but
hopefully not too many. Anyhow, I don't think waiting longer to
commit this is necessarily going to help, so let's see what happens...

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-10-21 14:44:41 Re: Default setting for autovacuum_freeze_max_age
Previous Message Stephen Frost 2016-10-21 13:47:54 Re: Renaming of pg_xlog and pg_clog