| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Something fishy happening on frogmouth |
| Date: | 2013-10-30 12:48:05 |
| Message-ID: | CA+TgmoZGsPf7iN-U+Q2Z4MWGeaWzF6jejR_05s61FG4Q5rEVoA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 30, 2013 at 8:22 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> I find it hard to believe this is the right fix. I know we have
> similar code in win32_shmem.c, but surely if size is a 32-bit unsigned
> quantity then size >> 0 is simply 0 anyway.
Gosh, I stand corrected. According to
http://msdn.microsoft.com/en-us/library/336xbhcz.aspx --
"The result is undefined if the right operand of a shift expression is
negative or if the right operand is greater than or equal to the
number of bits in the (promoted) left operand. No shift operation is
performed if the right operand is zero (0)."
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2013-10-30 13:07:43 | Re: Something fishy happening on frogmouth |
| Previous Message | Andres Freund | 2013-10-30 12:47:34 | Re: Something fishy happening on frogmouth |