| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Mithun Cy <mithun(dot)cy(at)enterprisedb(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: "Some tests to cover hash_index" |
| Date: | 2016-09-28 16:26:29 |
| Message-ID: | CA+TgmoZFxyipL3TaAU9=dct-Kksy6j+Gh1pVsj=F1NAUx_wY+w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 20, 2016 at 2:26 PM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> Why not use generate_series() queries to insert the appropriate number
> of tuples, instead of a handful of INSERT lines each time? Since each
> insert is a separate transaction, that would probably be faster.
>
> Why do you have a plpgsql function just to create a cursor? Wouldn't it
> be simpler to create the cursor in an SQL statement?
This patch hasn't been updated in over a week, so I'm marking it
Returned with Feedback. I think this is a good effort and I hope
something committable will come from it, but with 2 days left it's not
going to happen this CF.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2016-09-28 16:37:50 | Re: compiler warning read_objtype_from_string() |
| Previous Message | Peter Geoghegan | 2016-09-28 16:20:23 | Re: Tuplesort merge pre-reading |