Re: buffer locking fix for lazy_scan_heap

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: 高增琦 <pgf00a(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: buffer locking fix for lazy_scan_heap
Date: 2015-08-04 01:19:34
Message-ID: CA+TgmoZFZhVbwzsYganayJjSiiJK-0TQE2gEvT+NUYJYGCi1_Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Aug 3, 2015 at 12:03 AM, 高增琦 <pgf00a(at)gmail(dot)com> wrote:
> sorry for asking this really old commit.
>
> http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=7ab9b2f3b79177e501a1ef90ed004cc68788abaf
>
> I could not understand why "releases the lock on the buffer" is
> a problem since vacuum will lock and check the page bit again before
> set the vm. Did I missed something?

Hmm, you might be right. It certainly seems safer to do all the work
without releasing the buffer lock temporarily in the middle, but maybe
the old way wasn't actually broken.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2015-08-04 03:15:11 Re: Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file
Previous Message Michael Paquier 2015-08-04 01:14:00 Re: Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. );