| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Badrul Chowdhury <bachow(at)microsoft(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Satyanarayana Narlapuram <Satyanarayana(dot)Narlapuram(at)microsoft(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Re: protocol version negotiation (Re: Libpq PGRES_COPY_BOTH - version compatibility) |
| Date: | 2017-11-15 21:11:35 |
| Message-ID: | CA+TgmoZCis1TCcsMa8eu8wgT0K71fL_HQL+ZNtOEHwrxh804ow@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 30, 2017 at 9:19 PM, Badrul Chowdhury <bachow(at)microsoft(dot)com> wrote:
> Thank you for the comprehensive review! We are very much in the early stages of contributing to the PG community and we clearly have lots to learn, but we look forward to becoming proficient and active members of the pg community.
>
> Regarding the patch, I have tested it extensively by hand and it works great.
I spent a little more time looking at this patch today. I think that
the patch should actually send NegotiateProtocolVersion when *either*
the requested version is differs from the latest one we support *or*
an unsupported protocol option is present. Otherwise, you only find
out about unsupported protocol options if you also request a newer
minor version, which isn't good, because it makes it hard to add new
protocol options *without* bumping the protocol version.
Here's an updated version with that change and a proposed commit message.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| pgwire-be-rmh-v2.patch | application/octet-stream | 11.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-11-15 21:21:56 | Re: Transaction control in procedures |
| Previous Message | Thomas Munro | 2017-11-15 21:11:25 | Re: [HACKERS] Parallel Hash take II |