| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
| Cc: | Julien Rouhaud <rjuju123(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Peter Geoghegan <pg(at)bowt(dot)ie>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: pg14 psql broke \d datname.nspname.relname |
| Date: | 2022-01-17 21:54:12 |
| Message-ID: | CA+TgmoZCMKQE9H6VONi_D9vcvOFr1R5TU69LBc6qUCDtt_bs3g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 17, 2022 at 1:06 PM Mark Dilger
<mark(dot)dilger(at)enterprisedb(dot)com> wrote:
> > On Jan 15, 2022, at 12:28 AM, Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote:
> > Could you send a rebased version?
> Yes. Here it is:
This is not a full review, but I just noticed that:
+ * dotcnt: how many separators were parsed from the pattern, by reference.
+ * Can be NULL.
But then:
+ Assert(dotcnt != NULL);
On a related note, it's unclear why you've added three new arguments
to processSQLNamePattern() but only one of them gets a mention in the
function header comment.
It's also pretty clear that the behavior of patternToSQLRegex() is
changing, but the function header comments are not.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2022-01-17 21:55:10 | Re: Add last commit LSN to pg_last_committed_xact() |
| Previous Message | Tom Lane | 2022-01-17 21:38:05 | Re: a misbehavior of partition row movement (?) |